On 13 September 2016 at 23:11, Marty Faltesek <mfaltesek@xxxxxxxxxx> wrote:
[...]
> +int
> +ath10k_cal_data_alloc(struct ath10k *ar, void **buf)
> +{
> + u32 hi_addr;
> + __le32 addr;
> + int ret;
> +
> + vfree(*buf);
> + *buf = vmalloc(QCA988X_CAL_DATA_LEN);
Shouldn't you use ar->hw_params to get hw-specific caldata length?
[...]
> @@ -1714,6 +1750,12 @@ int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode)
>
> INIT_LIST_HEAD(&ar->arvifs);
>
> + /*
> + * We are up now, so no need to cache calibration data.
> + */
The comment style is:
/* comment */
If it's multi-line it should be:
/* comment
* comment
*/
Ditto for other instances.
[...]
> @@ -1757,6 +1799,11 @@ void ath10k_core_stop(struct ath10k *ar)
> lockdep_assert_held(&ar->conf_mutex);
> ath10k_debug_stop(ar);
>
> + /*
> + * Cache caclibration data while stopped.
typo. "calibration"
Michał
