Amitkumar Karwar <akarwar@xxxxxxxxxxx> writes: >> Like discussed earlier, the firmware names are supposed to be stable. I >> consider them to be an interface between kernel and user space. Instead >> of changing the driver you should actually rename the firmware file. I'm >> planning to take this anyway but in the future please pay extra >> attention to do this properly. > > Thanks for accepting the patch. We will stick to the same name for > 8997 and ensure v3/v4 etc won't be used for future chipsets/firmwares. Good, thanks. >> My recommendation is to keep the firmware name simple as possible and >> get rid of any extra cruft, for example in this case a good name would >> be "mrvl/usb8997.bin". That extra "usb" and "combo_v4" don't bring any >> benefit. >> > > 'combo' here indicates it's a combine firmware image for bluetooth and > wifi. Firmware images with bluetooth only OR WiFi only functionality > are also possible. Example use case: We support PCIe function level > reset feature as a recovery mechanism. With this mechanism, WiFi > recovery can happen by re-downloading WiFi only firmware without > affecting bluetooth functionality for PCIe-USB8997 chipset. Ok, makes sense. > 'usbusb' here indicates this firmware is for a USB-USB8997 chipset > where WiFi and bluetooth are over USB bus. There would be a different > firmware if chipset is USB-UART8997 where bluetooth is via UART. So the bluetooth via UART chip would be 'usbuart'? Sounds reasonable then. -- Kalle Valo
