"Sharon, Sara" <sara.sharon@xxxxxxxxx> writes: >> The commit log doesn't tell a lot. I started to wonder why use >> debugfs and not the proper interface through mac80211? > > This is RX packet injection, not TX. So the injection goes up - from > the driver to mac80211. Since we use it to test some mvm data path > stuff, we don't want to inject at mac80211 level. > >> But reading from the code makes me suspect that this isn't really >> normal packet injection, more like passing full descriptors to the >> hw. Did I understand correctly? > > For injecting at driver level we need the injected packet to contain a > fake of the HW descriptor for the driver processing. This descriptor > isn't being passed to the hw, but to the driver since it is RX. The > code isn't creating the descriptor, but it is validating length and > other checks to make sure we won't access invalid memory or so. Ah, makes sense. No need to resend this, but in the future please try to explain higher level design like this in the commit log. That avoids a lot of guessing (wrong) for me and others. -- Kalle Valo
