Hi Kalle, > From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] > Sent: Wednesday, September 14, 2016 10:29 PM > To: Amitkumar Karwar > Cc: linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; Nishant Sarmukadam; > Ganapathi Bhat > Subject: Re: [PATCH 2/2] mwifiex: firmware name correction for usb8997 > chipset > > Amitkumar Karwar <akarwar@xxxxxxxxxxx> writes: > > > From: Ganapathi Bhat <gbhat@xxxxxxxxxxx> > > > > Similar to pcie8997 chipset, first firmware submitted for usb8997 > > chipset will be usbusb8997_combo_v4.bin. This patch corrects the name > > used in driver. > > > > Signed-off-by: Ganapathi Bhat <gbhat@xxxxxxxxxxx> > > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > --- > > drivers/net/wireless/marvell/mwifiex/usb.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/wireless/marvell/mwifiex/usb.h > > b/drivers/net/wireless/marvell/mwifiex/usb.h > > index 1b49c52..30e8eb8 100644 > > --- a/drivers/net/wireless/marvell/mwifiex/usb.h > > +++ b/drivers/net/wireless/marvell/mwifiex/usb.h > > @@ -46,7 +46,7 @@ > > #define USB8766_DEFAULT_FW_NAME "mrvl/usb8766_uapsta.bin" > > #define USB8797_DEFAULT_FW_NAME "mrvl/usb8797_uapsta.bin" > > #define USB8801_DEFAULT_FW_NAME "mrvl/usb8801_uapsta.bin" > > -#define USB8997_DEFAULT_FW_NAME "mrvl/usb8997_uapsta.bin" > > +#define USB8997_DEFAULT_FW_NAME "mrvl/usbusb8997_combo_v4.bin" > > Like discussed earlier, the firmware names are supposed to be stable. I > consider them to be an interface between kernel and user space. Instead > of changing the driver you should actually rename the firmware file. I'm > planning to take this anyway but in the future please pay extra > attention to do this properly. Thanks for accepting the patch. We will stick to the same name for 8997 and ensure v3/v4 etc won't be used for future chipsets/firmwares. > My recommendation is to keep the firmware name simple as possible and > get rid of any extra cruft, for example in this case a good name would > be "mrvl/usb8997.bin". That extra "usb" and "combo_v4" don't bring any > benefit. > 'combo' here indicates it's a combine firmware image for bluetooth and wifi. Firmware images with bluetooth only OR WiFi only functionality are also possible. Example use case: We support PCIe function level reset feature as a recovery mechanism. With this mechanism, WiFi recovery can happen by re-downloading WiFi only firmware without affecting bluetooth functionality for PCIe-USB8997 chipset. 'usbusb' here indicates this firmware is for a USB-USB8997 chipset where WiFi and bluetooth are over USB bus. There would be a different firmware if chipset is USB-UART8997 where bluetooth is via UART. I agree that we should have avoided v4. Regards, Amitkumar Karwar
