>It checks that everything matches up with capabilities, but it doesn't check that if you specified NL80211_ATTR_TX_RATES you didn't do something stupid like specifying it for 2.4GHz while your AP is >starting up on 5GHz. Thanks for the suggestion . We shall ensure to consider the beacon rates configured on the specific band corresponding to the Channel on which the AP is getting started. nl80211_parse_tx_bitrate_mask shall anyways validate the beacon rates configured with the ones supported / advertised on a specific band. >It also doesn't check that you specified exactly one rate, but it's not clear how else this would work? I can think of the following options here . 1. Consider these rates as only the preference ( in order ) to the host driver , but the User space would have no way of knowing what the driver has selected. 2. Limit this beacon rate to only one . cfg80211 to verify that there is exactly one rate to be specified. Is option 2 a viable option ? Regards, Sunil -----Original Message----- From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] Sent: Sunday, August 7, 2016 1:28 AM To: Undekari, Sunil Dutt <usdutt@xxxxxxxxxxxxxxxx>; Kushwaha, Purushottam <pkushwah@xxxxxxxxxxxxxxxx> Cc: linux-wireless@xxxxxxxxxxxxxxx; Malinen, Jouni <jouni@xxxxxxxxxxxxxxxx>; Kondabattini, Ganesh <ganeshk@xxxxxxxxxxxxxxxx>; Kalikot Veetil, Mahesh Kumar <mkalikot@xxxxxxxxxxxxxxxx>; Hullur Subramanyam, Amarnath <amarnath@xxxxxxxxxxxxxxxx> Subject: Re: [PATCH] cfg80211: Add support for user configurable beacon data rate On Sat, 2016-08-06 at 04:38 +0000, Undekari, Sunil Dutt wrote: > > > > Doesn't this have to check that it actually got information for the > > right band? > Hi Johannes , > nl80211_parse_tx_bitrate_mask ( a new wrapper to the existing > functionality in nl80211_set_tx_bitrate_mask ) does this , isn't ? > It checks that everything matches up with capabilities, but it doesn't check that if you specified NL80211_ATTR_TX_RATES you didn't do something stupid like specifying it for 2.4GHz while your AP is starting up on 5GHz. It also doesn't check that you specified exactly one rate, but it's not clear how else this would work? johannes
