RE: [PATCH] cfg80211: Add support for user configurable beacon data rate

["Undekari, Sunil Dutt" <usdutt@xxxxxxxxxxxxxxxx>]

> Doesn't this have to check that it actually got information for the right band?
Hi Johannes ,
nl80211_parse_tx_bitrate_mask ( a new wrapper to the existing functionality in nl80211_set_tx_bitrate_mask ) does this , isn't ? 

Regards,
Sunil



-----Original Message-----
From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] 
Sent: Friday, August 5, 2016 2:33 PM
To: Kushwaha, Purushottam <pkushwah@xxxxxxxxxxxxxxxx>
Cc: linux-wireless@xxxxxxxxxxxxxxx; Malinen, Jouni <jouni@xxxxxxxxxxxxxxxx>; Undekari, Sunil Dutt <usdutt@xxxxxxxxxxxxxxxx>; Kondabattini, Ganesh <ganeshk@xxxxxxxxxxxxxxxx>; Kalikot Veetil, Mahesh Kumar <mkalikot@xxxxxxxxxxxxxxxx>; Hullur Subramanyam, Amarnath <amarnath@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] cfg80211: Add support for user configurable beacon data rate

On Fri, 2016-08-05 at 10:05 +0530, Purushottam Kushwaha wrote:
> 
> +static int nl80211_parse_tx_bitrate_mask(struct genl_info *info,
> +					 struct cfg80211_bitrate_mask *mask);

I think you should move the function instead.

> @@ -3457,6 +3459,11 @@ static int nl80211_start_ap(struct sk_buff 
> *skb, struct genl_info *info)
>  	err = cfg80211_validate_beacon_int(rdev,
> params.beacon_interval);
>  	if (err)
>  		return err;
> +	if (info->attrs[NL80211_ATTR_TX_RATES]) {
> +		err = nl80211_parse_tx_bitrate_mask(info,
> &params.beacon_rate);
> +		if (err)
> +			return err;
> +	}

Doesn't this have to check that it actually got information for the right band?

johannes
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f