Re: [PATCH] cfg80211: Add support for user configurable beacon data rate

[Johannes Berg <johannes@xxxxxxxxxxxxxxxx>]

On Fri, 2016-08-05 at 10:05 +0530, Purushottam Kushwaha wrote:
> 
> +static int nl80211_parse_tx_bitrate_mask(struct genl_info *info,
> +					 struct cfg80211_bitrate_mask *mask);

I think you should move the function instead.

> @@ -3457,6 +3459,11 @@ static int nl80211_start_ap(struct sk_buff
> *skb, struct genl_info *info)
>  	err = cfg80211_validate_beacon_int(rdev,
> params.beacon_interval);
>  	if (err)
>  		return err;
> +	if (info->attrs[NL80211_ATTR_TX_RATES]) {
> +		err = nl80211_parse_tx_bitrate_mask(info,
> &params.beacon_rate);
> +		if (err)
> +			return err;
> +	}

Doesn't this have to check that it actually got information for the
right band?

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html