Hi Jouni, > From: Jouni Malinen [mailto:j@xxxxx] > Sent: Thursday, July 21, 2016 9:22 PM > To: Amitkumar Karwar > Cc: Kalle Valo; linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; Nishant > Sarmukadam > Subject: Re: [PATCH 5/9] mwifiex: cfg80211 set_default_mgmt_key handler > > On Thu, Jul 21, 2016 at 09:18:11AM +0000, Amitkumar Karwar wrote: > > > From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] Is it correct to > > > ignore the key index? I see that brcmfmac ignores it as well but I > > > want to still confirm this. > > > > > > Does this mean that with this patcfh mwifiex properly supports MFP? > > > > Yes. We do pass MFP tests with this patch. > > Did you test IGTK rekeying? This patch looks exactly as broken as it did > the last time it was proposed more than a year ago and after the same > concern not receiving any reaction.. hostapd will configure two > different IGTKs with different Key IDs and change the TX key on the AP > once all associated STAs have the new key. If the driver does not > support updating the TX key index, either the old or the new STAs > associated after rekeying will not have the correct key. > Thanks for your feedback and guidance on this. I am trying to understand the problem you mentioned during IGTK rekeying. Today I ran tests with two stations connecting an AP. MFP is enabled on all of them. On hostapd side, my observation is add_key() is always called followed by set_default_mgmt_key(). set_default_mgmt_key() sets the key added by add_key() as default key. We are ignoring set_default_mgmt_key() and updating Tx key index during add_key() itself. Your concerns is we should not update Tx key index during add_key(). Reason is IGTK rekeying is not yet completed with all stations. Right? Regards, Amitkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
