Hi Kalle, > From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] > Sent: Monday, July 18, 2016 10:49 PM > To: Amitkumar Karwar > Cc: linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; Nishant Sarmukadam > Subject: Re: [PATCH 5/9] mwifiex: cfg80211 set_default_mgmt_key handler > > Amitkumar Karwar <akarwar@xxxxxxxxxxx> writes: > > > It is observed that hostapd fails to setup with management frame > > protection mode enabled when using mwifiex. This patch adds > > cfg80211_set_default_mgmt_key handler to resolve the problem. > > > > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > --- > > drivers/net/wireless/marvell/mwifiex/cfg80211.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > > b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > > index 8955f8c..bf95cca 100644 > > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > > @@ -484,6 +484,18 @@ mwifiex_cfg80211_add_key(struct wiphy *wiphy, > > struct net_device *netdev, } > > > > /* > > + * CFG802.11 operation handler to set default mgmt key. > > + */ > > +static int > > +mwifiex_cfg80211_set_default_mgmt_key(struct wiphy *wiphy, > > + struct net_device *netdev, > > + u8 key_index) > > +{ > > + wiphy_dbg(wiphy, "set default mgmt key, key index=%d\n", > key_index); > > + return 0; > > +} > > + > > +/* > > * This function sends domain information to the firmware. > > * > > * The following information are passed to the firmware - @@ -4002,6 > > +4014,7 @@ static struct cfg80211_ops mwifiex_cfg80211_ops = { > > .leave_ibss = mwifiex_cfg80211_leave_ibss, > > .add_key = mwifiex_cfg80211_add_key, > > .del_key = mwifiex_cfg80211_del_key, > > + .set_default_mgmt_key = mwifiex_cfg80211_set_default_mgmt_key, > > .mgmt_tx = mwifiex_cfg80211_mgmt_tx, > > .mgmt_frame_register = mwifiex_cfg80211_mgmt_frame_register, > > .remain_on_channel = mwifiex_cfg80211_remain_on_channel, > > Is it correct to ignore the key index? I see that brcmfmac ignores it as > well but I want to still confirm this. > > Does this mean that with this patcfh mwifiex properly supports MFP? > Yes. We do pass MFP tests with this patch. Regards, Amitkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
