On Sat, May 10, 2008 at 01:34:16PM +0200, Andrea Merello wrote: > Rtl8180: fix wrong parameter in RF code function invokation for gct radio > > The grf5101 RF code needs to invoke grf5101_write_phy_antenna every time the > channel is being switch. > > This should be done passing the channel number to that function. > Incorrectly we were passing the same value that is written on the > channel RF register. > This may cause problems when operating on ch 14. > > This patch fixes it. > > Thanks to Alessandro Di Marco who found this issue! > > > signed-off-by: Andrea Merello <andreamrl@xxxxxxxxxx> > --- > > --- a/drivers/net/wireless/rtl8180_grf5101.c 2008-02-02 > 14:48:52.000000000 +0100 > +++ b/drivers/net/wireless/rtl8180_grf5101.c 2008-02-02 > 14:52:59.000000000 +0100 > @@ -87,7 +87,7 @@ static void grf5101_rf_set_channel(struc > write_grf5101(dev, 0x0B, chan); > write_grf5101(dev, 0x07, 0x1000); > > - grf5101_write_phy_antenna(dev, chan); > + grf5101_write_phy_antenna(dev, conf->channel); > } > > static void grf5101_rf_stop(struct ieee80211_hw *dev) CC [M] drivers/net/wireless/rtl8180_grf5101.o drivers/net/wireless/rtl8180_grf5101.c: In function ‘grf5101_rf_set_channel’: drivers/net/wireless/rtl8180_grf5101.c:91: warning: passing argument 2 of ‘grf5101_write_phy_antenna’ makes integer from pointer without a cast This one is also whitespace-damaged... John -- John W. Linville linville@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
