On Sat, May 10, 2008 at 01:30:12PM +0200, Andrea Merello wrote: > Rtl8180: fix wrong parameter in RF code funcion invokation for philips radio > > The sa2400 RF code needs to invoke sa2400_write_phy_antenna every time the > channel is being switch. > > This should be done passing the channel number to that function. > Incorrectly we were passing the same value that is written on the > channel RF register. > This may cause problems when operating on ch 14. > > This patch fixes it. > > Thanks to Alessandro Di Marco who found this issue! > > > signed-off-by: Andrea Merello <andreamrl@xxxxxxxxxx> > --- > > --- a/drivers/net/wireless/rtl8180_sa2400.c 2008-02-02 > 14:48:52.000000000 +0100 > +++ b/drivers/net/wireless/rtl8180_sa2400.c 2008-02-02 > 14:49:44.000000000 +0100 > @@ -85,7 +85,7 @@ static void sa2400_rf_set_channel(struct > > write_sa2400(dev, 7, txpw); > > - sa2400_write_phy_antenna(dev, chan); > + sa2400_write_phy_antenna(dev, conf->channel); > > write_sa2400(dev, 0, chan); > write_sa2400(dev, 1, 0xbb50); CC [M] drivers/net/wireless/rtl8180_sa2400.o drivers/net/wireless/rtl8180_sa2400.c: In function ‘sa2400_rf_set_channel’: drivers/net/wireless/rtl8180_sa2400.c:89: warning: passing argument 2 of ‘sa2400_write_phy_antenna’ makes integer from pointer without a cast Also, the patch is whitespace-damaged and it should be "Signed-off-by" (note the capital letter) if you don't mind. :-) Thanks, John -- John W. Linville linville@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
