On Wed, Dec 23, 2015 at 3:18 AM, Jes Sorensen <Jes.Sorensen@xxxxxxxxxx> wrote: > Daniel Lenski <dlenski@xxxxxxxxx> writes: >> On Mon, Dec 21, 2015 at 9:53 AM, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote: >>> On 12/20/2015 08:28 PM, Dan Lenski wrote: >>>> >>>> Signed-off-by: Dan Lenski <dlenski@xxxxxxxxx> >>> >>> >>> The commit message should be in this patch rather than in the non-patch >>> previous mail. If this patch were to be accepted, all that explanation would >>> be lost! >>> >>> Rather than issuing a warning when the MAC is changed after the interface >>> has been brought up, have you considered changing the value of >>> rtw_adapter->bup to zero whenever the connection goes down? Would that help >>> with the confusion in the user-space tools? >> >> No. rtw_adapter isn't visible to userspace at all. NetworkManager, for >> instance, seems to get confused when *any* up interface changes its >> MAC address. >> >> bup should *not* be reset to zero when the device is closed. >> netdev_open23a() checks or bup==0 and calls rtl8723au_hal_init() to do >> hw initialization and firmware download if so. This is unnecessary >> after subsequent re-opening, which is why netdev_close() doesn't set >> bup=0. >> >>> NACK. >> >> I'll resubmit with the commit message fixed and the warning removed. >> > > In addition, do *not* overwrite the eeprompriv.mac_addr - that struct is > a clean copy of the eeprom's data and should not be modified. > > Please changed the dev entry and make sure they driver updates from > there instead. I left that part alone (overwriting the eeprompriv.mac_addr) because the existing code relies on it containing the correct *current* MAC address in numerous places. But, fair enough. This will require a much more complex patch, because there are numerous functions which assume that eeprompriv.mac_addr is the current address. (And some of these functions only receive the struct rtw_adapter as an argument, rather than the complete netdev.) > Second, please CC me directly as the driver maintainer. > > For longer term, please try out rtl8xxxu, hopefully we can > rm -rf drivers/staging/rtl8723au soon. Woah, I didn't know that driver existed. I will take a look. Thanks, Dan -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
