On 12/20/2015 08:28 PM, Dan Lenski wrote:
Signed-off-by: Dan Lenski <dlenski@xxxxxxxxx>
The commit message should be in this patch rather than in the non-patch previous mail. If this patch were to be accepted, all that explanation would be lost!
Rather than issuing a warning when the MAC is changed after the interface has been brought up, have you considered changing the value of rtw_adapter->bup to zero whenever the connection goes down? Would that help with the confusion in the user-space tools?
NACK. Larry
--- drivers/staging/rtl8723au/os_dep/os_intfs.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/os_intfs.c b/drivers/staging/rtl8723au/os_dep/os_intfs.c index b8848c2..228e19f 100644 --- a/drivers/staging/rtl8723au/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723au/os_dep/os_intfs.c @@ -240,8 +240,11 @@ static int rtw_net_set_mac_address(struct net_device *pnetdev, void *p) struct rtw_adapter *padapter = netdev_priv(pnetdev); struct sockaddr *addr = p; - if (!padapter->bup) - ether_addr_copy(padapter->eeprompriv.mac_addr, addr->sa_data); + if (padapter->bup) + DBG_8723A_LEVEL(_drv_warning_, "Trying to set MAC address while bup =%d\n", padapter->bup); + ether_addr_copy(padapter->eeprompriv.mac_addr, addr->sa_data); + ether_addr_copy(pnetdev->dev_addr, addr->sa_data); + return 0; }
-- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
