Hi all, The r8723au driver silently leaves the MAC address unchanged when attempting to set it. This was mentioned in a Debian security bug for macchanger (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=774898;msg=46) and more recently has been causing me frustration with captive portals at that give a short window of free connectivity, and refuse further connections from the same MAC address. This patch: * Correctly sets the dev_addr field of struct net_device. The code to do this was for some reason commented out in the original version of the driver from Realtek: http://github.com/lwfinger/rtl8723au/blob/bc13943b872dc666a3cfa55407e7f9965f0aab52/os_dep/os_intfs.c#L827 * Removes the restriction wherein the MAC address cannot be set after the network driver is first brought up, and replaces it with a warning. Because rtw_adapter->bup is set to 1 when the device is first opened, and _never_ set back to 0, it would be necessary to reload the module to change the MAC with this restriction. I have tested repeatedly changing the MAC address while the device is up, and there seem to be no ill effects, other than userspace tools getting confused. Thanks, Dan Dan Lenski (1): enable setting MAC address for r8723au drivers/staging/rtl8723au/os_dep/os_intfs.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
