On Sun, May 04, 2008 at 04:22:20AM +0200, Johannes Berg wrote: > > Yes, wireless always needs at least 24 bytes, but more likely 34 > (encryption+QoS). However, I just increased LL_MAX_HEADER to 54 and that > doesn't seem to have helped. How did you test it? > What's wrong with, instead, doing skb_orphan() and then > pskb_expand_head()? That seems to have the same effect. If you packet sticks around for long enough then this skews the accounting. In any case, thinking too much about optimising this part is a waste of time because we should be thinking about having enough head room in the packet so that we don't have to expand it in the first place except for the odd packet. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
