On Sun, May 04, 2008 at 04:08:36AM +0200, Johannes Berg wrote: > > So, what is mac80211 supposed to do? It needs up to 54 bytes of > available headroom (for an encrypted mesh packet which currently can't > really happen, but anyway) yet it cannot pskb_expand_head() either. > Cloning each packet seems even more expensive, and just like skb_orphan > subverts the purpose of the socket accounting. If all/the majority of your packets need the space then put it in LL_MAX_HEADER. In any case, you should always expand the packet if necessary in your output routine since LL_MAX_HEADER is just a hint. Yes cloning is expensive compared to not having to do it, but as long as this is only done for the exception then it's irrelevant. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
