> > Radiotap explicitly allows you to have a longer length than you need so > > maybe we should just make sure to align things? > > are you talking about the alignment of the radiotap header itself? no, i just > took care about the alignment requirements of the radiotap fields, relative > to the start of radiotap. but it would be easy to add some additional length > in ieee80211_rx_radiotap_len() and just leave that empty at the end. > > i think i don't understand all alignment requirements though... Well all those stores there are usual 32/16-bit stores which will fault on some architectures. See Documentation/unaligned-access.txt. Adding some padding to make the radiotap header start at a mod8 boundary would help. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part