Search Linux Wireless

Re: [PATCH 2/2] mac80211: make rx radiotap header more flexible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Radiotap explicitly allows you to have a longer length than you need so
> > maybe we should just make sure to align things?
> 
> are you talking about the alignment of the radiotap header itself? no, i just 
> took care about the alignment requirements of the radiotap fields, relative 
> to the start of radiotap. but it would be easy to add some additional length 
> in ieee80211_rx_radiotap_len() and just leave that empty at the end.
> 
> i think i don't understand all alignment requirements though...

Well all those stores there are usual 32/16-bit stores which will fault
on some architectures. See Documentation/unaligned-access.txt. Adding
some padding to make the radiotap header start at a mod8 boundary would
help.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux