On Wednesday 30 April 2008 16:12:52 Johannes Berg wrote: > > > Radiotap explicitly allows you to have a longer length than you need so > > > maybe we should just make sure to align things? > > > > are you talking about the alignment of the radiotap header itself? no, i > > just took care about the alignment requirements of the radiotap fields, > > relative to the start of radiotap. but it would be easy to add some > > additional length in ieee80211_rx_radiotap_len() and just leave that > > empty at the end. > > > > i think i don't understand all alignment requirements though... > > Well all those stores there are usual 32/16-bit stores which will fault > on some architectures. See Documentation/unaligned-access.txt. Adding > some padding to make the radiotap header start at a mod8 boundary would > help. so if i assume that the skb already starts at such a mod8 boundary it should be enough to make the length of the radiotap header a multiple of 8, right? please check the patch which i will post shortly. bruno -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
