On 22 April 2015 at 08:27, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: > Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> writes: > >> Michal Kazior <michal.kazior@xxxxxxxxx> writes: >> >>>> To reduce support questions from the users it would be nice to give few >>>> good examples how to use this with iw. And also it makes it easier to >>>> test the patch. If you could send something I can add it to the commit >>>> log. >>> >>> Should work: >>> >>> iw wlan0 set bitrates legacy 1 6 12 ht-mcs 1 2 3 >>> iw wlan0 set bitrates legacy-5 mcs-5 7 8 9 Oh, I just noticed I typo'ed: s/mcs-5/ht-mcs-5/. >>> iw wlan0 set bitrates legacy-5 24 ht-mcs-5 vht-mcs-5 1:0-9 >>> >>> Won't work: >>> >>> iw wlan0 set bitrates legacy-5 ht-mcs-5 vht-mcs-5 1:0-5 >>> iw wlan0 set bitrates vht-mcs-5 2:7-9 >>> >>> (note the invalid VHT MCS ranges) >> >> Thanks, I added these to the commit log. > > Actually, I had some problems: > > # iw wlan0 set bitrates legacy-2.4 1 6 12 ht-mcs-2.4 1 2 3 > command failed: Invalid argument (-22) > # iw wlan0 set bitrates legacy-5 1 6 12 ht-mcs-5 1 2 3 > command failed: Invalid argument (-22) There's no 1mbps (CCK) on 5GHz. If you remove the "1" from legacy-5 it should work. > # iw wlan0 set bitrates legacy-5 vht-mcs-5 7 8 9 > command failed: Invalid argument (-22) There's a couple of problems here: * The syntax for VHT MCS is different: vht-mcs-<2.4|5> <NSS:MCSx,MCSy... | NSS:MCSx-MCSy>* You used syntax from HT MCS: ht-mcs-<2.4|5> <MCS index>* The correct way to express this would be: iw wlan0 set bitrates legacy-5 vht-mcs-5 1:7,8,9 or iw wlan0 set bitrates legacy-5 vht-mcs-5 1:7-9 assuming you wanted NSS=1 (VHT MCS don't imply NSS just like HT MCS do) * As per commit log you can't use just any VHT MCS; you're limited to none, 0-7, 0-8, 0-9. You can set a *single* VHT MCS as per 51ab1a0a09a8 ("ath10k: add set_bitrate_mask callback") though. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html