> On Wed, 2015-01-07 at 15:39 +0100, Lorenzo Bianconi wrote: > >> > Does it really make sense to ask the driver to do "automatic"? After >> > all, there are other limits in mac80211 (like 11h from the AP and >> > regulatory) that need to be considered. So perhaps if userspace says >> > "automatic", the driver should still see only "limited"? >> > >> >> IMHO "automatic" means lower driver has to take into account just >> channel/regulatory constraints (that is ath9k behavior), since the >> user/mac80211 does not cap TX power, whereas "limited" means the >> user/mac80211 has set a limit for emitted power, so that configuration >> has to be taken into account. > > Well, mac80211 always gives you a max TX power value though - and if > it's only the maximum regulatory permitted on that channel. So there's > always a valid upper bound - unlike the userspace API where "automatic" > means that you have no idea of an upper bound. Inside the kernel you > always have an upper bound, so "automatic" doesn't make that much sense? > Sounds good, now I have clearer vision :) I will overwrite bss_conf nl80211_tx_power_setting value in ieee80211_set_tx_power() when txpower type is set to NL80211_TX_POWER_AUTOMATIC from userspace. Moreover should we set nl80211_tx_power_setting to NL80211_TX_POWER_LIMITED in ieee80211_handle_pwr_constr() when the station receives a power constraint in beacon frames? What do you think? > johannes > Regards, Lorenzo -- UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch; unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp; umount; make clean; sleep -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
