> On Tue, 2015-01-06 at 18:41 +0100, Lorenzo Bianconi wrote: > >> + * @txpower_type: TX power adjustment used to control per packet Transmit >> + * Power Control (TPC) in lower driver for the current vif. In particular >> + * TPC is enabled if value passed in %txpower_type is >> + * NL80211_TX_POWER_AUTOMATIC (no limit from userspace) or >> + * NL80211_TX_POWER_LIMITED (allow using less than specified from >> + * userspace), whereas TPC is disabled if %txpower_type is set to >> + * NL80211_TX_POWER_FIXED (use value configured from userspace) > > I was going to apply this, but now I have second thoughts. > > Does it really make sense to ask the driver to do "automatic"? After > all, there are other limits in mac80211 (like 11h from the AP and > regulatory) that need to be considered. So perhaps if userspace says > "automatic", the driver should still see only "limited"? > IMHO "automatic" means lower driver has to take into account just channel/regulatory constraints (that is ath9k behavior), since the user/mac80211 does not cap TX power, whereas "limited" means the user/mac80211 has set a limit for emitted power, so that configuration has to be taken into account. Maybe we have just left to set txpower_type to NL80211_TX_POWER_LIMITED for the current vif when TX power is limited by the AP (802.11h). What do you think? Are there any other cases when TX power is limited by mac80211 (excluding 802.11h and when TX power is limited by the user)? > johannes > Regards, Lorenzo -- UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch; unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp; umount; make clean; sleep -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
