Thanks for reviewing. I'll send out a new patch series as soon as I'm through all of your comments. On Wed, Sep 03, 2014 at 01:56:40PM +0200, Johannes Berg wrote: > Please format the code like this: > > static bool > ieee80211_find_80211h_pwr_constr(struct ieee80211_sub_if_data *sdata, > struct ieee80211_channel *channel, > const u8 *country_ie, u8 > country_ie_len, > const u8 *pwr_constr_elem, > int *chan_pwr, int *pwr_reduction) Done. > Do we need the pwr_reduction? Couldn't we just return it? We don't > handle 0/negative anyway, do we? We could do the calculation directly in ieee80211_find_80211h_pwr_constr; however, then we couldn't message the calculation in the printk (it currently says e.g. 0 (17 - 23) dBm). I don't know if that is important or not, but I opted to let it stay as-is. >> -static u32 ieee80211_handle_pwr_constr(struct ieee80211_sub_if_data *sdata, > >> +static bool ieee80211_handle_pwr_constr(struct ieee80211_sub_if_data *sdata, > > I think you meant to keep u32 here? Otherwise return values from the > function simply get converted to 0/1 which doesn't seem right. You're right; this function is supposed to return a bitmask. Fixed. /* Steinar */ -- Homepage: http://www.sesse.net/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
