On Fri, 2014-08-29 at 19:27 +0200, Steinar H. Gunderson wrote:
> ieee80211_find_80211h_pwr_constr
Please format the code like this:
static bool
ieee80211_find_80211h_pwr_constr(struct ieee80211_sub_if_data *sdata,
struct ieee80211_channel *channel,
const u8 *country_ie, u8
country_ie_len,
const u8 *pwr_constr_elem,
int *chan_pwr, int *pwr_reduction)
Do we need the pwr_reduction? Couldn't we just return it? We don't
handle 0/negative anyway, do we?
> -static u32 ieee80211_handle_pwr_constr(struct ieee80211_sub_if_data *sdata,
> +static bool ieee80211_handle_pwr_constr(struct ieee80211_sub_if_data *sdata,
I think you meant to keep u32 here? Otherwise return values from the
function simply get converted to 0/1 which doesn't seem right.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
