On Mon, 2014-09-01 at 13:26 +0200, Henning Rogge wrote: > The following patch adds NL80211_CMD_GET_MPP as a new nl80211 command that > allows to query the content of the 'mesh proxy path' table of mac80211s via > 'get' or 'dump' operation. For review and merging, and to make it more obvious to you as well when writing commit logs/documentation/etc I'd prefer if you'd split this up into separate cfg80211 and mac80211 patches. > + int (*get_mpp)(struct wiphy *wiphy, struct net_device *dev, > + u8 *dst, u8 *mpp, struct mpath_info *pinfo); > + int (*dump_mpp)(struct wiphy *wiphy, struct net_device *dev, > + int idx, u8 *dst, u8 *mpp, > + struct mpath_info *pinfo); Should dst/mpp be const? Or are those output parameters? Should it really be mpath_info? I thought this was some other thing? Probably just need more documentation :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
