+ spin_lock_bh(&ar->data_lock); + + /* First 4 bytes are a messages-dropped-due-to-overflow counter, + * and should not be recorded in the dbglog buffer, so we skip + * them. + */ + ath10k_debug_dbglog_add(ar, skb->data + 4, skb->len - 4);Can't we just: struct wmi_dbg_msg { __le32 num_dropped_due_to_overflow; u8 payload[0]; // is this an array of u8 or __le32 actually? };
When I wrote this, I was more paranoid about exposing any possible details of firmware. It is an array of 32-bit ints in firmware, and it decodes as ints instead of bytes, so probably u32 payload instead of u8. Thanks, Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
