On 19 August 2014 11:39, Michal Kazior <michal.kazior@xxxxxxxxx> wrote:
I miss-clicked, sorry for the noise.
> On 19 August 2014 10:23, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote:
>> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>>
>> They may be dumped through the firmware dump debugfs
>> file.
>>
>> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx>
>> ---
>> drivers/net/wireless/ath/ath10k/wmi.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
>> index 23acbadeb8fa..eafc565240f1 100644
>> --- a/drivers/net/wireless/ath/ath10k/wmi.c
>> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
>> @@ -1290,6 +1290,16 @@ static int ath10k_wmi_event_debug_mesg(struct ath10k *ar, struct sk_buff *skb)
>>
>> trace_ath10k_wmi_dbglog(skb->data, skb->len);
>>
>> + spin_lock_bh(&ar->data_lock);
>> +
>> + /* First 4 bytes are a messages-dropped-due-to-overflow counter,
>> + * and should not be recorded in the dbglog buffer, so we skip
>> + * them.
>> + */
>> + ath10k_debug_dbglog_add(ar, skb->data + 4, skb->len - 4);
Can't we just:
struct wmi_dbg_msg {
__le32 num_dropped_due_to_overflow;
u8 payload[0]; // is this an array of u8 or __le32 actually?
};
Michał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
