Joe Perches <joe@xxxxxxxxxxx> writes: >> This introduces a new checkpatch warning: >> >> drivers/net/wireless/ath/ath10k/wmi.h:214: ERROR: spaces required around that ':' (ctx:VxE) >> >> But I think that's just a false warning and I should ignore it. Any >> other ideas? > > I don't get a warning with this patch. > > What's the last git commit id of the checkpatch version > you used? I was using a pretty old version of checkpatch (I have a local copy of it) but now I updated it to commit ae3ccc4678. I still see the warning plus a new fallthrough warning (see below). > $ ./scripts/checkpatch.pl --strict ath10k.diff > total: 0 errors, 0 warnings, 0 checks, 471 lines checked With that command line I don't see it either. But normally I use -f and that's when I see it: $ scripts/checkpatch.pl --strict --ignore NETWORKING_BLOCK_COMMENT_STYLE,PARENTHESIS_ALIGNMENT -f drivers/net/wireless/ath/ath10k/wmi.h ERROR: spaces required around that ':' (ctx:VxE) #214: FILE: drivers/net/wireless/ath/ath10k/wmi.h:214: + default: ^ WARNING: Possible switch case/default not preceeded by break or fallthrough comment #214: FILE: drivers/net/wireless/ath/ath10k/wmi.h:214: + default: total: 1 errors, 1 warnings, 0 checks, 4803 lines checked NOTE: Ignored message types: NETWORKING_BLOCK_COMMENT_STYLE PARENTHESIS_ALIGNMENT drivers/net/wireless/ath/ath10k/wmi.h has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html