On Sat, 2014-08-02 at 09:39 +0300, Kalle Valo wrote: > Michal Kazior <michal.kazior@xxxxxxxxx> writes: > > > The 10.x and main firmware branches have > > conflicting WMI service bitmap definitions. > > > > This also fixes WMI services parsing on big-endian > > hosts and changes debugfs output to be more human > > friendly. > > > > Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx> > > [...] > > > + SVCSTR(WMI_SERVICE_TX_ENCAP) > > + SVCSTR(WMI_SERVICE_BURST) > > + SVCSTR(WMI_SERVICE_SMART_ANTENNA_SW_SUPPORT) > > + SVCSTR(WMI_SERVICE_SMART_ANTENNA_HW_SUPPORT) > > default: > > - return "UNKNOWN SERVICE\n"; > > + return NULL; > > This introduces a new checkpatch warning: > > drivers/net/wireless/ath/ath10k/wmi.h:214: ERROR: spaces required around that ':' (ctx:VxE) > > But I think that's just a false warning and I should ignore it. Any > other ideas? I don't get a warning with this patch. What's the last git commit id of the checkpatch version you used? $ ./scripts/checkpatch.pl --strict ath10k.diff total: 0 errors, 0 warnings, 0 checks, 471 lines checked -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html