On Tue, 2014-02-04 at 12:29 +0100, Michal Kazior wrote: > >> +void ieee80211_csa_disconnect(struct ieee80211_sub_if_data *sdata) > >> +{ > >> + struct ieee80211_local *local = sdata->local; > >> + struct ieee80211_if_managed *ifmgd = &sdata->u.mgd; > >> + > >> + switch (sdata->vif.type) { > >> + case NL80211_IFTYPE_STATION: > >> + case NL80211_IFTYPE_P2P_CLIENT: > >> + ieee80211_queue_work(&local->hw, > >> + &ifmgd->csa_connection_drop_work); > >> + break; > >> + default: > >> + /* XXX: other iftypes should be halted too */ > > > > Good point. This case would suck, but we need to do something because > > the stations will think that we're on the different channel at this > > point. But maybe instead the userspace should be notified instead of > > halting here? It could retry with a count 0, for example. > > Ideally cfg80211 should be the one stopping interfaces. This way you'd > get AP stopped event (recently done by Johannes) and userspace can do > something about (e.g. re-start APs from scratch). Well, if mac80211 ends up doing that, we just need an API call to send the event and reset cfg80211's info. I didn't add one yet because the locking might get a bit tricky, but others actually wanted such an API for firmware bugs anyway. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html