On Tue, 2014-01-07 at 18:34 +0100, Karl Beldan wrote: > On Tue, Jan 07, 2014 at 04:33:38PM +0100, Johannes Berg wrote: > > On Mon, 2014-01-06 at 19:01 +0100, Karl Beldan wrote: > > > > > + if (vif->csa_active) { > > > + vp->csa_bcn_cnt++; > > > > I don't see any readers of this variable? > > > > > + if (vp->csa_finished) { > > > + wiphy_debug(hw->wiphy,"%s extra CSA-beacon\n", __func__); > > > + } else if (ieee80211_csa_is_complete(vif)) { > > > + wiphy_debug(hw->wiphy, > > > + "%s CSA complete after %d beacons\n", > > > + __func__, vp->csa_bcn_cnt); > > > > except for the debug, but is that really useful? > > > In a sim/debug module ? I found it appropriate ;) > Seriously I have no strong opinion on this matter, as I said, feel free > to do whatever you want with this, there's nothing critical here. > > > > + ieee80211_csa_finish(vif); > > > + vp->csa_finished = true; > > > > and if we remove the other debug we can also remove the csa_finished > > variable, that seems reasonable to me since mac80211 would already warn > > anyway, no? > > > I just got rid of a big blahblah I got for this, please, adjust as you > see fit as I have no strong opinion on this matter. Well, heh. That'd mean learning all about the API? I think I have a patch somewhere from somebody else that looked simpler, I think I'll take that and see what happens. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html