Search Linux Wireless

Re: [PATCH v4] mac80211_hwsim: claim CSA support for AP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2014-01-06 at 19:01 +0100, Karl Beldan wrote:

> +	if (vif->csa_active) {
> +		vp->csa_bcn_cnt++;

I don't see any readers of this variable?

> +		if (vp->csa_finished) {
> +			wiphy_debug(hw->wiphy,"%s extra CSA-beacon\n", __func__);
> +		} else if (ieee80211_csa_is_complete(vif)) {
> +			wiphy_debug(hw->wiphy,
> +				    "%s CSA complete after %d beacons\n",
> +				    __func__, vp->csa_bcn_cnt);

except for the debug, but is that really useful?

> +			ieee80211_csa_finish(vif);
> +			vp->csa_finished = true;

and if we remove the other debug we can also remove the csa_finished
variable, that seems reasonable to me since mac80211 would already warn
anyway, no?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux