On Fri, 2008-02-01 at 23:21 +0200, Tomas Winkler wrote: > On Feb 1, 2008 10:11 PM, Dan Williams <dcbw@xxxxxxxxxx> wrote: > > > > On Fri, 2008-02-01 at 21:47 +0200, Tomas Winkler wrote: > > > On Feb 1, 2008 9:15 PM, Dan Williams <dcbw@xxxxxxxxxx> wrote: > > > > On Fri, 2008-02-01 at 20:29 +0200, Tomas Winkler wrote: > > > > > On Feb 1, 2008 2:42 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > > > > > > > > > > > > cfg80211/nl80211 - overview, get Johannes to disseminate knowledge > > > > > > > because email isn't optimal for this. I haven't had enough time to jump > > > > > > > into it yet, but the fact that Johannes is the vast majority of the > > > > > > > effort here is worrisome. Having a reference implementation (airo, > > > > > > > atmel, maybe libertas) of a fullmac driver ported to cfg80211 would > > > > > > > probably be very useful, even just to get a sense of how the API works. > > > > > > > > > > > > cfg80211/nl80211 is no further for fullmac drivers than a year ago, all > > > > > > work it got so far is for hostapd. > > > > > > > > > > > > I have a fairly decent plan how to add association/... support but it > > > > > > lacks execution because it's completely boring work that doesn't buy us > > > > > > any new features since we still have to support wext. > > > > > > > > > > > Security setting is a bit broken. There is a missing separation > > > > > between static and dynamic./WPA wep keys. > > > > > > > > How do you mean? > > > > > > In wext there is encoding setting for static keys only for wep and > > > extended encoding for dynamic keys including wep keys. In mac80211 > > > both setting are funneled to the same point which is incorrect since > > > the usage is not the same. The major problem is in HW acceleration. > > > The static wep keys are passed as belonging to the station with > > > broadcast address and the driver cannot distinguish if the wep key is > > > dynamic key for the bcast address or it is a static wep key that has > > > to be used for all traffic. The problem is of course visible mostly in > > > AP mode. > > > > Ah; right. I don't think there really should be a difference in the API > > to differentiate static vs. dynamic WEP keys. Instead each key sent to > > the driver (be it WEP, TKIP, or CCMP) should definitely have a BSSID to > > which it applies which the userspace caller must set, and if the key is > > to be used for _all_ traffic, then maybe have a flag for that or use > > 00:00:00:00:00:00 as the BSSID. If we use "magic" #s like 00:00... for > > the BSSID then we've got to be sure to document that magic # which is > > where we all fell down with WEXT. Hence I prefer flags, but whatever. > > > > Sure this is not good to make too many interfaces, but a flag must be > added, i prefer to not abusing BSSID address. > One other difference is that there might be 4 keys for static wep > while only one wep key in WPA. Definitely; there will certainly need to be flags or a 'wep_key_idx' field for WEP key indexes. Should probably just have a 'u32 flags' somewhere that goes along with each key. Dan - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
