On Mon, 2013-01-21 at 10:54 +0100, Arend van Spriel wrote: > >> + if (type == NL80211_IFTYPE_P2P_DEVICE && info->attrs[NL80211_ATTR_MAC]) > >> + nla_memcpy(¶ms.macaddr[0], info->attrs[NL80211_ATTR_MAC], > >> + ETH_ALEN); > > > > It seems like this might need a capability parameter or something, so > > wpa_s knows this will take effect. OTOH, wpa_s can query the MAC address > > afterwards, so it's not really needed, so I applied it. > > Not sure if I can follow. I did submit wpa_s patch for flagging the P2P > device capability. Are you suggesting an additional flag here to > indicate whether the MAC address can be configured by wpa_s? Yes, or maybe it's not needed as wpa_s could read the address back after the interface is created, and see whether it stuck. Right now, for example, with mac80211 it wouldn't be used at all. > > I would also like to see a mac80211 change though to make it take effect > > there. > > See what I can do. I guess it does involve mac80211 device drivers as > well, right? Oh, I think there's no mac80211 driver using P2P device yet. :-) I have a patch for iwlwifi but I'm not merging it until wpa_s gets "more ready" johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
