On 01/16/2013 11:17 PM, Johannes Berg wrote: > On Tue, 2013-01-08 at 10:17 +0100, Arend van Spriel wrote: >> --- a/net/wireless/nl80211.c >> +++ b/net/wireless/nl80211.c >> @@ -2079,6 +2079,10 @@ static int nl80211_new_interface(struct sk_buff *skb, struct genl_info *info) >> !(rdev->wiphy.interface_modes & (1 << type))) >> return -EOPNOTSUPP; >> >> + if (type == NL80211_IFTYPE_P2P_DEVICE && info->attrs[NL80211_ATTR_MAC]) >> + nla_memcpy(¶ms.macaddr[0], info->attrs[NL80211_ATTR_MAC], >> + ETH_ALEN); > > It seems like this might need a capability parameter or something, so > wpa_s knows this will take effect. OTOH, wpa_s can query the MAC address > afterwards, so it's not really needed, so I applied it. Not sure if I can follow. I did submit wpa_s patch for flagging the P2P device capability. Are you suggesting an additional flag here to indicate whether the MAC address can be configured by wpa_s? > (I changed the subject to say "configure", "determine" seems a bit vague > to me, the way I read it it could possibly also mean "allow to get" it) Potaitoe, Patatoe, fine by me ;-) > I would also like to see a mac80211 change though to make it take effect > there. See what I can do. I guess it does involve mac80211 device drivers as well, right? Gr. AvS > johannes > > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
