On Tue, 2013-01-08 at 10:17 +0100, Arend van Spriel wrote: > As per email discussion Jouni Malinen pointed out that: > > "P2P message exchanges can be executed on the current operating channel > of any operation (both P2P and non-P2P station). These can be on 5 GHz > and even on 60 GHz (so yes, you _can_ do GO Negotiation on 60 GHz). > > As an example, it would be possible to receive a GO Negotiation Request > frame on a 5 GHz only radio and then to complete GO Negotiation on that > band. This can happen both when connected to a P2P group (through client > discoverability mechanism) and when connected to a legacy AP (assuming > the station receive Probe Request frame from full scan in the beginning > of P2P device discovery)." > > This means that P2P messages can be sent over different radio devices. > However, these should use the same P2P device address so it should be > able to provision this from user-space. This patch adds a parameter for > this to struct vif_params which should only be used during creation of > the P2P device interface. > > Cc: Jouni Malinen <j@xxxxx> > Cc: Greg Goldman <ggoldman@xxxxxxxxxxxx> > Cc: Jithu Jance <jithu@xxxxxxxxxxxx> > Signed-off-by: Arend van Spriel <arend@xxxxxxxxxxxx> > --- > Hi Johannes, > > Best wishes. Found this patch catching dust on my shelf/branch. Cleaning > up in 2013 so here you have it :-) :-) > --- a/net/wireless/nl80211.c > +++ b/net/wireless/nl80211.c > @@ -2079,6 +2079,10 @@ static int nl80211_new_interface(struct sk_buff *skb, struct genl_info *info) > !(rdev->wiphy.interface_modes & (1 << type))) > return -EOPNOTSUPP; > > + if (type == NL80211_IFTYPE_P2P_DEVICE && info->attrs[NL80211_ATTR_MAC]) > + nla_memcpy(¶ms.macaddr[0], info->attrs[NL80211_ATTR_MAC], > + ETH_ALEN); It seems like this might need a capability parameter or something, so wpa_s knows this will take effect. OTOH, wpa_s can query the MAC address afterwards, so it's not really needed, so I applied it. (I changed the subject to say "configure", "determine" seems a bit vague to me, the way I read it it could possibly also mean "allow to get" it) I would also like to see a mac80211 change though to make it take effect there. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
