On Fri, Dec 14, 2012 at 12:59 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> From: Johannes Berg <johannes.berg@xxxxxxxxx>
>
> The last fixes re-added the RCU synchronize penalty
> on roaming to fix the races. Split up sta_info_flush()
> now to get rid of that again, and let managed mode
> (and only it) delay the actual destruction.
>
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
> ---
The patchset looks good. thanks for fixing it :)
> +/**
> + * sta_info_flush - flush matching STA entries from the STA table
> + *
> + * Returns the number of removed STA entries.
> + *
> + * @sdata: sdata to remove all stations from
> + */
> +static inline int sta_info_flush(struct ieee80211_sub_if_data *sdata)
> +{
> + int ret = sta_info_flush_defer(sdata);
> +
> + if (ret)
> + sta_info_flush_cleanup(sdata);
> +
> + return ret;
> +}
> +
but i think this is wrong - there might already be stations in the cleanup list.
you should always call sta_info_flush_cleanup.
Eliad.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
