Search Linux Wireless

Re: [PATCH 2/5] mac80211: use del_timer_sync for final sta cleanup timer deletion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2012-12-13 at 23:59 +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@xxxxxxxxx>
> 
> This is a very old bug, but there's nothing that prevents the
> timer from running while the module is being removed when we
> only do del_timer() instead of del_timer_sync().
> 
> The timer should normally not be running at this point, but
> it's not clearly impossible (or we could just remove this.)

Ok it's very unlikely -- the timer would have to rearm itself and the
fire the exact same moment we try to del_timer() it, so it's still
running when we return, and then we'd have to unload the module quickly
enough to invalidate that code that's running there ... it's a bit of a
stretch, but not completely impossible.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux