On 12/12/2012 02:02 PM, Johannes Berg wrote:
On Wed, 2012-12-12 at 13:54 -0800, greearb@xxxxxxxxxxxxxxx wrote:
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
In an earlier version of this code, testing found that sometimes
either sta wasn't found or sta->sdata was NULL. This caused
crashes of course. So, add checks with WARN_ON_ONCE to
catch these.
I don't know what you tested, but there's absolutely no way that
sta->sdata is NULL... *Especially* not after sta_info_get_bss(), I mean,
look at that function. But once it's on the list it can't be NULL, so
I'm not going to apply this patch.
In the future, I'd appreciate if you could avoid avoid sending patches
for drivers and mac80211 etc. in one series, it gets confusing with who
applies what etc.
Ok, it was quite a while ago..maybe I was hitting other upstream bugs or
bugs of my own.
For what it's worth, I haven't noticed my WARN_ON hitting.
I'll drop this patch from my tree.
Thanks,
Ben
johannes
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
