On Tuesday, December 11, 2012 09:28:32 PM Kalle Valo wrote: > Vladimir Kondratiev <qca_vkondrat@xxxxxxxxxxxxxxxx> writes: > > > There are 2 different things: > > - sub-menu for "Atheros Wireless cards" family > > - module ath.ko with common Atheros code > > > > Until now, they both used to depend on the same Kconfig variable ATH_COMMON. > > Thus, being "Atheros card" and "depending on ath.ko" was the same. > > > > To allow module to belong to the > > "Atheros Wireless cards" family but not use ath.ko, > > 2 conditions above need to be separated. > > > > So, this patch introduce new Kconfig variable ATH_CARDS for belonging > > to the "Atheros Wireless Cards" family; while ATH_COMMON becomes hidden > > variable to express dependency on common Atheros code in ath.ko. Modules > > that depend on this common code now express it by setting ATH_COMMON. > > > > Right now, ath6kl do not depend on common code and thus do not set ATH_COMMON. > > > > Signed-off-by: Vladimir Kondratiev <qca_vkondrat@xxxxxxxxxxxxxxxx> > > This broke ath6kl, it get compiled unless I enable ath9k or some other > atheros driver. > > Reverting 23c1d7f6597 or adding "select ATH_COMMON" to ath6kl fixes > this. Any ideas what's wrong? It's not obvious to me from looking at > Kconfig files. > Interesting. I just compiled with ath6kl only, have no ATH_COMMON in .config. Compiles with no problem. Maybe something with your setup? Can you elaborate what error do you see? Thanks, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
