On Fri, Dec 7, 2012 at 11:23 AM, Luciano Coelho <coelho@xxxxxx> wrote: > On Wed, 2012-11-28 at 11:42 +0200, Arik Nemtsov wrote: >> Update the 18xx FW status private part to include Tx related link >> priorities. Introduce new HW ops to determine link priority per chip >> family. >> >> For 18xx the changes are: >> - Suspended links are at most low priority and Tx for them is stopped >> beyond the suspend threshold. >> - Active links now get their thresholds directly from FW >> - There's a new "stop" threshold for active links, at which point a link >> stops receiving new packets. >> >> Update the min 18xx FW version required to make sure suspended links >> bitmap is advertised by the FW. > > This doesn't apply anymore, I'll remove it. Sounds good. Thanks. > > >> Signed-off-by: Arik Nemtsov <arik@xxxxxxxxxx> >> --- > > Otherwise this patch looks good! > > Just to understand better, why is the firmware deciding on the > thresholds? Does it make some internal magic itself to know the number > of links (including multi-channel) and adjust the thresholds > accordingly? Isn't this something we could (or should?) do in the kernel > side? Yes the FW decides on the thresholds based on the multi-channel state. Basically links are suspended and resumed all the time. The FW knows some stuff we don't know, for instance the real speed of the link and if a BA session is ongoing. Makes it easy for them to tweak these values. Of course they could export all the information, but I don't think it really matters one way or the other. It works well this way. Arik -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
