> <marco.porsch@xxxxxxxxxxxxxxxxxxx> wrote:>> If the beacon is already enabled, do not modify the beacon timer. This causes >> a hard TBTT adjustment and may cause mischief for powersave or synchronization.j
> > It might be clearer if you explain this patch actually defers "TBTT" > adjustment until the next beacon.This commit is supposed to not change the TBTT at all, if the beacon is not enabled/disabled. Or do I misunderstand you here? Please clarify.
>> Signed-off-by: Marco Porsch <marco.porsch@xxxxxxxxxxxxxxxxxxx> >> --- >> drivers/net/wireless/mac80211_hwsim.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
>> index bc763d2..abfa7e6 100644 >> --- a/drivers/net/wireless/mac80211_hwsim.c >> +++ b/drivers/net/wireless/mac80211_hwsim.c>> @@ -1174,7 +1174,7 @@ static int mac80211_hwsim_config(struct ieee80211_hw *hw, u32 changed)
>> data->power_level = conf->power_level; >> if (!data->started || !data->beacon_int) >> del_timer(&data->beacon_timer); >> - else >> + else if (!timer_pending(&data->beacon_timer))>> mod_timer(&data->beacon_timer, jiffies + data->beacon_int);
> > There is an immediate beacon timer adjustment in > mac80211_hwsim_bss_info_changed() as well.But that other one really has to change the TBTT because it changes the beacon interval.
--Marco
begin:vcard fn:Marco Porsch n:Porsch;Marco org:Chemnitz University of Technology;Communication Networks adr;quoted-printable;quoted-printable:Fakult=C3=A4t f=C3=BCr Elektrotechnik und Informationstechnik , Professur= Kommunikationsnetze;;Technische Universit=C3=A4t Chemnitz;Chemnitz;;D - 09107;Germany email;internet:marco.porsch@xxxxxxxxxxxxxxxxxxx title:Dipl.-Ing. tel;work:+49 371 531 37523 version:2.1 end:vcard
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
