Search Linux Wireless

Re: [PATCH 2/3] ath5k: noise calibration also for rf511x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Nov 23, 2007 6:25 AM, Nick Kossifidis <mickflemm@xxxxxxxxx> wrote:
> 2007/11/23, Bruno Randolf <bruno@xxxxxxxxxxxxx>:
> > also perform full noise calibration in ath5k_hw_rf511x_calibrate() instead of
> > just writing the bit.
> >
> > Changes-licensed-under: ISC
> > Signed-off-by: Bruno Randolf <bruno@xxxxxxxxxxxxx>
> > ---
> >  drivers/net/wireless/ath5k/phy.c |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath5k/phy.c b/drivers/net/wireless/ath5k/phy.c
> > index 9b91121..f250c2e 100644
> > --- a/drivers/net/wireless/ath5k/phy.c
> > +++ b/drivers/net/wireless/ath5k/phy.c
> > @@ -1702,8 +1702,7 @@ static int ath5k_hw_rf511x_calibrate(struct ath5k_hw *ah,
> >                 ((u32)q_coff) | ((u32)i_coff << AR5K_PHY_IQ_CORR_Q_I_COFF_S));
> >
> >  done:
> > -       /* Start noise floor calibration */
> > -       AR5K_REG_ENABLE_BITS(ah, AR5K_PHY_AGCCTL, AR5K_PHY_AGCCTL_NF);
> > +       ath5k_hw_noise_floor_calibration(ah, channel->freq);
> >
> >         /* Request RF gain */
> >         if (channel->val & CHANNEL_5GHZ) {
> > --
> > 1.5.3.4
> >
> >
>
> Actually just writing the bit enables nf calibration, what this patch
> does is that it also reads the value and check if it's ok.

Know why it wasn't done before? Have you guys tested this without
impact on performance on the affected hardware? Just curious.

  Luis
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux