On Fri, 08 Jun 2007 09:17:55 +0800, Zhu Yi wrote: > On Thu, 2007-06-07 at 22:39 +0200, Jiri Benc wrote: > > A global variable? Common for all devices you have in your computer? > > That's broken. > > OK, it can be fixed. But it is that broken if you treat it as a debug > helper and don't use it on mulitple interfaces simultaneously. It's broken even when it's just a debug code. Please fix it. > > Triggering an event just by writing anything to the debugfs file > > doesn't seem like a clean and intelligible way to configure things. (*) > > Also, are you aware this is just a _debug_ stuff? Given the fact that > > you're calling (for example) ieee80211_send_addts from debugfs handler > > only, it looks like you're misusing it as an user space API. > > If you follow the thread, I will write a user space API with cfg80211. > This one for debugging only. Ok, I somehow missed that. I suppose that's fine for wireless-dev then. Except that I'm still not happy with (*). But that's probably just a matter of taste and therefore doesn't constitute a real problem in a debug code. Thanks, Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
