On Thu, 2007-06-07 at 22:39 +0200, Jiri Benc wrote:
> A global variable? Common for all devices you have in your computer?
> That's broken.
OK, it can be fixed. But it is that broken if you treat it as a debug
helper and don't use it on mulitple interfaces simultaneously.
> > +
> > +#define DEBUGFS_QOS_FILE(name, f) \
> > +static ssize_t qos_ ##name## _write(struct file *file, \
> > + const char __user *userbuf, \
> > + size_t count, loff_t *ppos) \
> > +{ \
> > + struct ieee80211_sub_if_data *sdata = file->private_data; \
> > + \
> > + f(sdata->dev, &sdata->u.sta, &_tspec); \
> > + \
> > + return count; \
> > +} \
>
> Triggering an event just by writing anything to the debugfs file
> doesn't seem like a clean and intelligible way to configure things.
>
> Also, are you aware this is just a _debug_ stuff? Given the fact that
> you're calling (for example) ieee80211_send_addts from debugfs handler
> only, it looks like you're misusing it as an user space API.
If you follow the thread, I will write a user space API with cfg80211.
This one for debugging only.
-yi
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
