On Wed, 6 Jun 2007 16:22:39 +0800, Zhu Yi wrote:
> --- a/net/mac80211/debugfs_netdev.c
> +++ b/net/mac80211/debugfs_netdev.c
> @@ -87,6 +87,270 @@ static const struct file_operations name##_ops = { \
> IEEE80211_IF_FMT_##format(name, field) \
> __IEEE80211_IF_FILE(name)
>
> +static struct ieee80211_elem_tspec _tspec = {
> + .nominal_msdu_size = 200,
> + .inactivity_interval = 40,
> + .mean_data_rate = 40000,
> + .min_phy_rate = 6000000,
> + .surplus_band_allow = 8192,
> + .medium_time = 30,
> +};
> +static u8 _dls_mac[ETH_ALEN];
A global variable? Common for all devices you have in your computer?
That's broken.
> +
> +#define DEBUGFS_QOS_FILE(name, f) \
> +static ssize_t qos_ ##name## _write(struct file *file, \
> + const char __user *userbuf, \
> + size_t count, loff_t *ppos) \
> +{ \
> + struct ieee80211_sub_if_data *sdata = file->private_data; \
> + \
> + f(sdata->dev, &sdata->u.sta, &_tspec); \
> + \
> + return count; \
> +} \
Triggering an event just by writing anything to the debugfs file
doesn't seem like a clean and intelligible way to configure things.
Also, are you aware this is just a _debug_ stuff? Given the fact that
you're calling (for example) ieee80211_send_addts from debugfs handler
only, it looks like you're misusing it as an user space API.
Jiri
--
Jiri Benc
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
