Michael Wu wrote:
On Thursday 10 May 2007 10:56, Larry Finger wrote:
Why has the review of this patch been so strung out? Everything you comment
on here was in versions 1 & 2, but not mentioned in any review of those
versions.
Sorry, I've been busy. I'm pretty sure these issues are the last ones.
As to the usefulness of this function, I am testing in infrastructure, not
ad-hoc, mode, and the output matches the average rate in the log files if
debugging is enabled. If the address in u.sta.bssid is not correct, which
address should I be using? I still maintain that the user is entitled to
know the transmission rate from user space even if debugging is turned off,
and that this function is needed.
I didn't say infrastructure wasn't gonna work. That's the one that should
work. However, adhoc probably won't.
Sorry, I misread your previous comment.
Why is txrate in the sta_info structure an int? I think it should be a small, positive integer.
Would it not be better as a u8, or a u16 if you think a larger range is needed?
Larry
-Michael Wu
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
