On Sun, 2007-02-18 at 16:54 -0500, Pavel Roskin wrote: > On Sat, 2007-02-17 at 11:16 +0100, Johannes Berg wrote: > > On Sat, 2007-02-17 at 02:42 -0500, Pavel Roskin wrote: > > > hw.priv is set twice, and the second time it's set incorrectly to an > > > area relative to the master device, which wasn't allocated for private > > > data. > > > > Yeah, this is obviously correct. Guess I was drinking when I did these > > patches. I really wonder why I never saw any of your problems though, I > > do have bcm43xx running here. Not that the driver actually does anything > > for me, it always refuses to associate... > > Oh, and by the way, wouldn't it be reasonable to have an inline function > to calculate the pointer to the priv area instead of having an actual > field for the pointer? Yeah, I guess that isn't too hard to do. But if you think about what the current code will compile to that's also just an addition based on the struct size that is known at compile time. > Also, it looks like we need a generic macro for aligning sizes. I hated wrapping my head around it so I just made the padding explicit in the struct ;) johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
