Search Linux Wireless

Re: [PATCH] d80211: fix incorrect hw.priv setting in ieee80211_alloc_hw()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2007-02-17 at 02:42 -0500, Pavel Roskin wrote:
> hw.priv is set twice, and the second time it's set incorrectly to an
> area relative to the master device, which wasn't allocated for private
> data.

Yeah, this is obviously correct. Guess I was drinking when I did these
patches. I really wonder why I never saw any of your problems though, I
do have bcm43xx running here. Not that the driver actually does anything
for me, it always refuses to associate...

Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>

> Signed-off-by: Pavel Roskin <proski@xxxxxxx>
> ---
> 
>  net/d80211/ieee80211.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/net/d80211/ieee80211.c b/net/d80211/ieee80211.c
> index 456beb3..4f77e27 100644
> --- a/net/d80211/ieee80211.c
> +++ b/net/d80211/ieee80211.c
> @@ -4550,9 +4550,6 @@ struct ieee80211_hw *ieee80211_alloc_hw(size_t priv_data_len,
>  	mdev->ieee80211_ptr = &sdata->wdev;
>  	sdata->wdev.wiphy = wiphy;
>  
> -	local->hw.priv = (char *)mdev->priv +
> -			 ((sizeof(struct ieee80211_sub_if_data) +
> -			   NETDEV_ALIGN_CONST) & ~NETDEV_ALIGN_CONST);
>  	local->hw.queues = 1; /* default */
>  
>  	local->mdev = mdev;
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux