Search Linux Wireless

Re: [PATCH] d80211: fix incorrect hw.priv setting in ieee80211_alloc_hw()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2007-02-17 at 11:16 +0100, Johannes Berg wrote:
> On Sat, 2007-02-17 at 02:42 -0500, Pavel Roskin wrote:
> > hw.priv is set twice, and the second time it's set incorrectly to an
> > area relative to the master device, which wasn't allocated for private
> > data.
> 
> Yeah, this is obviously correct. Guess I was drinking when I did these
> patches. I really wonder why I never saw any of your problems though, I
> do have bcm43xx running here. Not that the driver actually does anything
> for me, it always refuses to associate...

Oh, and by the way, wouldn't it be reasonable to have an inline function
to calculate the pointer to the priv area instead of having an actual
field for the pointer?

Also, it looks like we need a generic macro for aligning sizes.

-- 
Regards,
Pavel Roskin

-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux