On Fri, Dec 23, 2016 at 11:27:24AM +0200, Vladimir Zapolskiy wrote: > On 12/23/2016 10:32 AM, Uwe Kleine-König wrote: > > Hello, > > > > On Fri, Dec 23, 2016 at 10:20:20AM +0200, Vladimir Zapolskiy wrote: > >> On 12/23/2016 03:55 AM, Guenter Roeck wrote: > >>> What is the ultimate conclusion of this exchange ? > >>> > >>> Are we going to get another version of the patch, or did everyone agree that > >>> the patch is good as it is and does not require further changes ? > >>> > >> > >> I can not imagine a different fix. > > > > my preferred fix would be: > > > > - add an imx35 compatible to all newer dtsi > > - update the driver to only write the wmcr on imx35 compatible devices > > adding only imx35. > > > > It breaks old DTS vs. new kernel compatibility, I've already mentioned this. Correct, and I didn't deny that. In my mail I pointed out the problem this imposes and I think it's small enough to not justify the complexity introduced in your proposed change. If we cannot agree then at least this needs to be better documented in the driver because otherwise someone makes a cleanup later dropping all the compatibles that are needed to keep backwards compatibility. But my suggestion is to first do the minimal fix, and if in the next merge window people lament about breakages on their machine, we can still extend the simple fix to a fully backwards compatible change. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
